summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* Fix the ipfw service status output when ipfw.ko isn't loadedmarkj2020-12-18
| | | | | | | | | | Reported by: lme Reviewed by: lme MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D27657 git-svn-id: http://svn.freebsd.org/base/head@368762 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* virtio_mmio: Fix feature negotiation copy-paste issue in r361943jrtc272020-12-18
| | | | | | | | | | | | | | This caused us to write to the low half of the feature word twice, once with the high bits and once with the low bits. Common legacy device implementations seem to be fairly lenient about being able to write to the feature bits multiple times, but Arm's models use a stricter implementation that will ignore the second write. This fixes using vtnet(4) on those models. Reported by: Jean-Philippe Brucker <jean-philippe@linaro.org> Pointy hat: jrtc27 git-svn-id: http://svn.freebsd.org/base/head@368761 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Fix abort in jemalloc extent coalescing.mw2020-12-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix error in extent_try_coalesce_impl(), which could cause abort to happen when trying to coalesce extents backwards. The error could happen because of how extent_before_get() function works. This function gets address of previous extent, by subtracting page size from current extent address. If current extent is located at PAGE_SIZE offset, this address resolved to 0x0000. An assertion in rtree_leaf_elm_lookup then caused the running program to abort. This problem was discovered when trying to build world on 32-bit machines with ASLR and PIE enabled. The problem was encountered on armv7 and i386 machines, but most likely other 32-bit architectures are affected as well. While this patch fixes one problem with buildworld on 32-bit platforms with ASLR, the build still fails, however it happens much later and due to lack of memory. The change is aligned with accepted fix in the upstream Jemalloc repository (https://github.com/jemalloc/jemalloc/pull/1973). As it doesn't apply on top of Jemalloc tree, its updated version was eventually merged: https://github.com/jemalloc/jemalloc/pull/2003 PR: 249937 Submitted by: Dawid Gorecki <dgr@semihalf.com> Obtained from: Semihalf Sponsored by: Stormshield Differential Revision: https://reviews.freebsd.org/D27025 git-svn-id: http://svn.freebsd.org/base/head@368756 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* tools/tools/locale: fix static-colldefyuripv2020-12-18
| | | | git-svn-id: http://svn.freebsd.org/base/head@368754 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* MFV r368746:delphij2020-12-18
| | | | | | | | | | | | Apply upstream fix 08968baec1122a58bb90d8f97ad948a75f8a5d69: Fix error cases when udp-connect is set and send() returns an error Obtained from: unbound git MFC after: 3 days git-svn-id: http://svn.freebsd.org/base/head@368751 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* tools/tools/locale: install generated files in current src checkoutyuripv2020-12-18
| | | | git-svn-id: http://svn.freebsd.org/base/head@368750 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* pci_iov: When pci_iov_detach(9) is called, destroy VF childrenkib2020-12-18
| | | | | | | | | | | | | | | | | instead of bailing out with EBUSY if there are any. If driver module is unloaded, or just device is forcibly detached from the driver, there is no way for driver to correctly unload otherwise. Esp. if there are resources dedicated to the VFs which prevent turning down other resources. Reviewed by: jhb Sponsored by: Mellanox Technologies / NVidia Networking MFC after: 1 week Differential revision: https://reviews.freebsd.org/D27615 git-svn-id: http://svn.freebsd.org/base/head@368749 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Fix issues with various VNC clients.grehan2020-12-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - support VNC version 3.3 (macos "Screen Sharing" builtin client) - wait until client has requested an update prior to sending framebuffer data - don't send an update if no framebuffer updates detected - increase framebuffer poll frequency to 30Hz, and double that when kbd/mouse input detected - zero uninitialized array elements in rfb_send_server_init_msg() - fix overly large allocation in rfb_init() - use atomics for flags shared between input and output threads - use #defines for constants This work was contributed by Marko Kiiskila, with reuse of some earlier work by Henrik Gulbrandsen. Clients tested : FreeBSD-current - tightvnc - tigervnc - krdc - vinagre Linux (Ubuntu) - krdc - vinagre - tigervnc - xtightvncviewer - remmina MacOS - VNC Viewer - TigerVNC - Screen Sharing (builtin client) Windows 10 - Tiger VNC - VNC Viewer (cursor lag) - UltraVNC (cursor lag) o/s independent - noVNC (browser) using websockify relay PR: 250795 Submitted by: Marko Kiiskila <marko@apache.org> Reviewed by: jhb (bhyve) MFC after: 3 weeks Relnotes: yes Differential Revision: https://reviews.freebsd.org/D27605 git-svn-id: http://svn.freebsd.org/base/head@368747 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* ice: quiet -Wredundant-declsrlibby2020-12-17
| | | | | | | | | | | Reapply r364240 after driver update in r365617. Reviewed by: lwhsu Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D27561 git-svn-id: http://svn.freebsd.org/base/head@368745 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* VFS_QUOTACTL: Remove needless casts of argbrooks2020-12-17
| | | | | | | | | | | | | | | The argument is a void * so there's no need to cast it to caddr_t. Update documentation to match function decleration. Reviewed by: freqlabs Obtained from: CheriBSD MFC after: 1 week Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D27093 git-svn-id: http://svn.freebsd.org/base/head@368744 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* net tests: Re-enable most if_clone testskp2020-12-17
| | | | | | | | All but one of these (tap_ipv6_up_stress) currently pass, so we should enable them so we don't regress. git-svn-id: http://svn.freebsd.org/base/head@368743 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Fix f_pkt_into_t typo.mav2020-12-17
| | | | | | | MFC after: 1 week git-svn-id: http://svn.freebsd.org/base/head@368742 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Use __containerof() instead of home-rolled versions.jhb2020-12-17
| | | | | | | | | | Reviewed by: imp, hselasky Obtained from: CheriBSD Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D27582 git-svn-id: http://svn.freebsd.org/base/head@368741 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Describe the commit message template our git hook script producesemaste2020-12-17
| | | | | | | Reported by: rpokala git-svn-id: http://svn.freebsd.org/base/head@368740 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Use a template assembly file for firmware object files.jhb2020-12-17
| | | | | | | | | | | | | | | | | | | | | Similar to r366897, this uses the .incbin directive to pull in a firmware file's contents into a .fwo file. The same scheme for computing symbol names from the filename is used as before to maximize compatiblity and not require rebuilding existing .fwo files for NO_CLEAN builds. Using ld -o binary requires extra hacks in linkers to either specify ABI options (e.g. soft- vs hard-float) or to ignore ABI incompatiblities when linking certain objects (e.g. object files with only data). Using the compiler driver avoids the need for these hacks as the compiler driver is able to set all the appropriate ABI options. Reviewed by: imp, markj Obtained from: CheriBSD Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D27579 git-svn-id: http://svn.freebsd.org/base/head@368739 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Cleanups to *ERR* compat shims.jhb2020-12-17
| | | | | | | | | | | | | | - Use [u]intptr_t casts to convert pointers to integers. - Change IS_ERR* to return bool instead of long. Reviewed by: manu Obtained from: CheriBSD Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D27577 git-svn-id: http://svn.freebsd.org/base/head@368738 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* chmod +x the git commit message prep hookemaste2020-12-17
| | | | git-svn-id: http://svn.freebsd.org/base/head@368737 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Add initial version of git commit message preparation hookemaste2020-12-17
| | | | | | | | | | | | | | | | | Start with a slightly modified version of the SVN commit template, to allow developers to experiment. This will be updated in the future as our process and techniques evolve. This can be installed by copying or symlinking into the .git/hooks/ directory. Feedback from: cem, jhb Reviewed by: imp Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D27633 git-svn-id: http://svn.freebsd.org/base/head@368736 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Fix a race in tty_signal_sessleader() with unlocked read of s_leader.kib2020-12-17
| | | | | | | | | | | | | | | | Since we do not own the session lock, a parallel killjobc() might reset s_leader to NULL after we checked it. Read s_leader only once and ensure that compiler is not allowed to reload. While there, make access to t_session somewhat more pretty by using local variable. PR: 251915 Submitted by: Jakub Piecuch <j.piecuch96@gmail.com> MFC after: 1 week git-svn-id: http://svn.freebsd.org/base/head@368735 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Update the unbound version number from r368478.cy2020-12-17
| | | | | | | | | | | Updating the version number is an extra manual step. Pointy hat to: cy Reported by: Herbert J. Skuhra <herbert _ gojira.at> MFC after: 3 days git-svn-id: http://svn.freebsd.org/base/head@368734 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* fd: reimplement close_range to avoid spurious relockingmjg2020-12-17
| | | | git-svn-id: http://svn.freebsd.org/base/head@368732 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* audit: rework AUDIT_SYSCLOSEmjg2020-12-17
| | | | | | | This in particular avoids spurious lookups on close. git-svn-id: http://svn.freebsd.org/base/head@368731 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* fd: refactor closefp in preparation for close_range reworkmjg2020-12-17
| | | | git-svn-id: http://svn.freebsd.org/base/head@368730 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* lualoader: fix lua-lint runkevans2020-12-17
| | | | | | | | | | | luacheck rightfully complains that i is unused in the show-module-options loop at the end (it was used for some debugging in the process). We've added a new pager module that's compiled in, so declare that as an acceptable global. git-svn-id: http://svn.freebsd.org/base/head@368729 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* lualoader: cli: provide a show-module-options loader commandkevans2020-12-17
| | | | | | | | | | | | | This effectively dumps everything lualoader knows about to the console using the libsa pager; that particular lua interface was added in r368591. A pager stub implementation has been added that just dumps the output as-is as a compat shim for older loader binaries that do not have lpager. This stub should be moved into a more appropriate .lua file if we add anything else that needs the pager. git-svn-id: http://svn.freebsd.org/base/head@368728 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* [ng_socket] Don't take the SOCKBUF_LOCK() twice in the RX data path.afedorov2020-12-17
| | | | | | | | | | | | This is just a minor optimization, but it's sensitive. This gives an improvement of 30-50 kpps. Reviewed by: kp, markj, glebius, lutz_donnerhacke.de Approved by: vmaffione (mentor) Sponsored by: vstack.com Differential Revision: https://reviews.freebsd.org/D27382 git-svn-id: http://svn.freebsd.org/base/head@368727 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Add IRQ resource to SPIBUSmanu2020-12-17
| | | | | | | | | | | | | | Add capability to SPIBUS to have child device with IRQ. For example many ADC chip have a dedicated pin to signal "data ready" and the host can just wait for a interrupt to go out and read the result. It is the same code as in R282674 and R282702 for IICBUS by Michal Meloun Submitted by: Oskar Holmund <oskar.holmlund@ohdata.se> Differential Revision: https://reviews.freebsd.org/D27396 git-svn-id: http://svn.freebsd.org/base/head@368725 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* arm: Remove samsung exnynos portmanu2020-12-17
| | | | | | | | | | Remove the exynos SoC support, this haven't been updated in a while, isn't present in GENERIC and nobody is motivated to resurect it. Differential Revision: https://reviews.freebsd.org/D24444 git-svn-id: http://svn.freebsd.org/base/head@368724 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Change POSIX compliance level for visibility of strerror_l(3).kib2020-12-17
| | | | | | | | | | | | | Third-party code tests for strerror_l(3) without specifying _POSIX_SOURCE, and then expects that the function is prototyped with _POSIX_SOURCE set to 200112. Reported and tested by: antoine Sponsored by: The FreeBSD Foundation MFC after: 13 days git-svn-id: http://svn.freebsd.org/base/head@368723 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* kyua: Only install examples if requestedmanu2020-12-17
| | | | | | | | Reviewed by: brooks Differential Revision: https://reviews.freebsd.org/D27638 git-svn-id: http://svn.freebsd.org/base/head@368722 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Drop EFI_STAGING_SIZE back down to 64Mimp2020-12-17
| | | | | | | | | | | vmware can't cope with anything larger than 64MB. Drop this back to 64MB everywhere but arm. PR: 251866 MFC After: 1 week git-svn-id: http://svn.freebsd.org/base/head@368721 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* [bhyve] virtio-net: Do not allow receiving packets until features have been ↵afedorov2020-12-17
| | | | | | | | | | | | | | | negotiated. Enforce the requirement that the RX callback cannot be called after a reset until the features have been negotiated. This fixes a race condition where the receive callback is called during a device reset. Reviewed by: vmaffione, grehan Approved by: vmaffione (mentor) Sponsored by: vstack.com Differential Revision: https://reviews.freebsd.org/D27381 git-svn-id: http://svn.freebsd.org/base/head@368720 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* bsdinstall: remove VTOC8 partition scheme optionmhorne2020-12-17
| | | | | | | | | | | | | Now that sparc64 has been removed, there are no kernels built with support for the VTOC8 partitioning scheme by default. Remove the option from the installer, as it is unsupported on all installer images produced by re@. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D27641 git-svn-id: http://svn.freebsd.org/base/head@368719 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Make non-debug kernels installable.nwhitehorn2020-12-17
| | | | | | | | Setting DEBUG_FLAGS results in make installkernel trying to install debug information that doesn't exist if the kernel was built without it. git-svn-id: http://svn.freebsd.org/base/head@368718 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* strerror.3: Add an example for perror()0mp2020-12-17
| | | | | | | | | | | This is a nice and quick reference. Reviewed by: jilles, yuripv MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D27623 git-svn-id: http://svn.freebsd.org/base/head@368714 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* freebsd-update: unconditionally regenerate passwd/login.conf fileskevans2020-12-17
| | | | | | | | | | | | | | | | | | | | | | | | | | The existing logic is nice in theory, but in practice freebsd-update will not preserve the timestamps on these files. When doing a major upgrade, e.g. from 12.1-RELEASE -> 12.2-RELEASE, pwd.mkdb et al. appear in the INDEX and we clobber the timestamp several times in the process of packaging up the existing system into /var/db/freebsd-update/files and extracting for comparisons. This leads to these files not getting regenerated when they're most likely to be needed. Measures could be taken to preserve timestamps, but it's unclear whether the complexity and overhead of doing so is really outweighed by the marginal benefit. I observed this issue when pkg subsequently failed to install a package that wanted to add a user, claiming that the user was removed in the process. bapt@ pointed to this pre-existing bug with freebsd-update as the cause. PR: 234014, 232921 Reviewed by: bapt, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D27635 git-svn-id: http://svn.freebsd.org/base/head@368713 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* /etc/services: attempt to bring the database to this century 2/2.pfg2020-12-17
| | | | | | | | | | | | | | | This is the final half of splitting r358153 in two, in order to avoid a build system bugs and being able to merge an earlier change to previous releases. Add a note to UPDATING to avoid people building from very old systems from having issues with mergemaster MFC after: 3 days (only 12-stable) Differential Revision: https://reviews.freebsd.org/D23621 git-svn-id: http://svn.freebsd.org/base/head@368712 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* nl_langinfo(3): document recognized item namesyuripv2020-12-17
| | | | | | | | | | | While here, remove .Tn macro usage (prompted by mandoc lint). PR: 251468 Reviewed by: bapt Differential Revision: https://reviews.freebsd.org/D27606 git-svn-id: http://svn.freebsd.org/base/head@368711 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Make mountcritremote dependent upon nfscbd.rmacklem2020-12-17
| | | | | | | | | | | | | | | | | Although it is not often needed, the nfscbd(8) should be running when NFSv4 mounts are done if callback functionality is required. Callback functionality is required for the NFSv4 server to issue delegations or pNFS layouts. This patch adds nfscbd to the mountcritremote's REQUIRED line to ensure it is started before NFS mounts specified in /etc/fstab are done. Reviewed by: 0mp Differential Revision: https://reviews.freebsd.org/D27506 git-svn-id: http://svn.freebsd.org/base/head@368710 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* newvers.sh: Speed up git_tree_modifiedbrooks2020-12-17
| | | | | | | | | | | | | | | | | We're looking for file content differences, so ask the question of git more directly. This helps a lot, saving tens of thousands of fork()s, when the builder and editor see different stat() results (e.g., UIDs), as they might with containers. Submitted by: Nathaniel Wesley Filardo <nwf20@cl.cam.ac.uk> Reviewed by: bdrewery, emaste, imp Obtained from: CheriBSD MFC after: 3 days Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D27646 git-svn-id: http://svn.freebsd.org/base/head@368709 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* riscv: increase GENERICSD gapmhorne2020-12-16
| | | | | | | | Leave more room for bootloaders at the beginning of the image. In particular, the u-boot files for the HiFive Unleashed are ~5MB in size. git-svn-id: http://svn.freebsd.org/base/head@368705 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Append the branch commit count to _SNAP_SUFFIX for developmentgjb2020-12-16
| | | | | | | | | snapshot builds. Sponsored by: Rubicon Communications, LLC (netgate.com) git-svn-id: http://svn.freebsd.org/base/head@368704 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* fd: remove redundant saturation check from fget_unlocked_seqmjg2020-12-16
| | | | | | | | | | | refcount_acquire_if_not_zero returns true on saturation. The case of 0 is handled by looping again, after which the originally found pointer will no longer be there. Noted by: kib git-svn-id: http://svn.freebsd.org/base/head@368703 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Complete steps 5 and 9 from Committer's guideotis2020-12-16
| | | | | | | | | Reviewed by: osa (mentor) Approved by: osa (mentor) Differential Revision: https://reviews.freebsd.org/D27632 git-svn-id: http://svn.freebsd.org/base/head@368701 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Fix whitespace in r368698jrtc272020-12-16
| | | | | | | MFC with: r368698 git-svn-id: http://svn.freebsd.org/base/head@368700 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Fix whitespace in comment modified by r368697jrtc272020-12-16
| | | | git-svn-id: http://svn.freebsd.org/base/head@368699 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Use the standard method for localizing of MSI-X table bar.mmel2020-12-16
| | | | | | | | | | | | | | Current way, hardcoded value plus heuristic is not conform to the PCI(e) specification and it fails on systems where MSI-X bar is not initialized by BIOS/ACPI (many arm or arm64 systems for example). Instead, use the standard PCI(e) capability for determining of MSIX table bar address. MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D27265 git-svn-id: http://svn.freebsd.org/base/head@368698 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Allocate right number of pages for the bounced buffers crossing the page.mmel2020-12-16
| | | | | | | | | | | | | | | | | | | | One of the disadvantages of our current busdma code is the fact that we process the bounced buffer in a page-by-page manner. This means that the short (subpage) buffer allocated across page boundaries is bounced to 2 separate pages. This suboptimal behavior is consistent across all platforms and can be related to (probably unimplementable or incompatible with bouncing) BUS_DMA_KEEP_PG_OFFSET flag. Therefore, allocate one additional page to be fully comply with this requirement. Discused with: markj PR: 251018 git-svn-id: http://svn.freebsd.org/base/head@368697 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* Remove contrib/binutils, unused after r368667emaste2020-12-16
| | | | git-svn-id: http://svn.freebsd.org/base/head@368696 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
* src.conf.5: regen after r368667, GDB retirementemaste2020-12-16
| | | | git-svn-id: http://svn.freebsd.org/base/head@368695 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f